Bonus #ProTip - If you are reviewing code from a new teammate, a junior, a woman, a person of color, a person with impostor syndrome, or any other person that stereotypically has to work against the suspicion of incompetence, you can literally affect their career. PLEASE DO THIS.
-
-
Prikaži ovu nit
-
So, I like this idea and you should do it, but aside from appealing to other senior devs to do this I don't know how to encourage it. Help me hack this: how could someone on the receiving end ask a teammate for praise without coming across as fishing for compliments?
Prikaži ovu nit -
LOL, side note: CW just told me "Um, I'm not sure if I should take credit or admit that the line was autogenerated." I laughed and said "ALWAYS TAKE THE WIN." (I'm only posting thing in case somebody else realizes it's autogenned. Kudos Rails team for making my CW look great!)
Prikaži ovu nit
Kraj razgovora
Novi razgovor -
-
-
Feel like I’m missing something here but that just looks like a date / time string with underscore separator. Kudos for the positive comments though

-
Nope, you've got it exactly--it's just that it's an integer, and something like 20200124123409 is hard to parse without counting off digits. You can just *read* 2020_01_24_123409. Feels so much nicer to me.
- Još 2 druga odgovora
Novi razgovor -
-
-
yup. 100% Also I …. Didn’t even know you could do that.
-
The underscores thing? Yeah, it's a fun stylistic decision in Ruby. Makes it a LOT easier to read numbers like 12_345_678.901_234_567
- Još 1 odgovor
Novi razgovor -
-
-
this is fantastic. It's the number one thing on how I do code reviews, toohttps://basthomas.github.io/on-code-reviews
- Još 3 druga odgovora
Novi razgovor -
-
-
I just mentally assume that if my pull request gets merged at all that the person considers me an undeniable genius. Helps a lot regardless of if its true or not.
-
See I’m different. I always just assume they merged it because it’s easier than going through all the little changes that would be required to get it up to their own standards and it would be easier to just fix it later.
Kraj razgovora
Novi razgovor -
Čini se da učitavanje traje već neko vrijeme.
Twitter je možda preopterećen ili ima kratkotrajnih poteškoća u radu. Pokušajte ponovno ili potražite dodatne informacije u odjeljku Status Twittera.