I'm not sure when it was written, which may account for some things, but it *definitely* isn't going to be the fastest strstr on x86 if SIMD is available. I'm skeptical that it will even be the fastest strstr even if SIMD is not available; we had SWAR tricks for string search...
Old glibc strstr() implementation: "I deliberately chose not to comment it. You should have at least as much fun trying to understand it, as I had to write it", h/t @johnregehr
https://sourceware.org/git/?p=glibc.git;a=blob;f=string/strstr.c;hb=9d13fb2413921c713f83efe331e8e4d219c62c6b …pic.twitter.com/kRR7U5jQkl
-
-
-
... even for non-SIMD platforms. The absence of unroll and the byte-by-byte nature of this... My guess is no. Everyone seems to think they can take a shot at this particular title but most amateur-hour implementations even of single-string search are usually not in the ballpark.
- 4 more replies
New conversation -
-
-
Frankly, that attitude is a 'teachable moment'.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
Looks like Stephen R. van den Berg had some great fun messing around with some Free Software that probably wasn't very important at the time.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
Six months later, joke’s on him.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
For some definition of “fun”
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
I remember this one time at my last job where we took a little time after a round of funding closed to go through our code to remove comments with vulgar language. The company is Australian. It was hilarious.
End of conversation
New conversation -
-
-
Hopefully we've learned a bit about appropriate open source collaboration since 1995!
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
Just looking at his coding style hurts.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.