It's not the code review part that is criticized, but the mandatory part. Anything mandatory risks becoming dogmatic or bureaucratic. (Such as a ban on ppt, or mandatory <= 6 pages.) It says a lot about an org when it requires a lot of ceremony to fix a typo in a code comment.
-
-
-
It says a lot about an org when code-review of a typo in a code comment would be seen as a burden or a big deal. Engineering cultures are not short of examples where "Just this once I don't need to have this checked" led to disaster.
- 4 more replies
New conversation -
-
-
I feel like a lot of criticism of code reviews is rooted in bad experiences with reviewers that are unnecessarily harsh or biased gatekeepers. It’s not that code reviews are bad but some reviewers definitely are
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
Maybe I’m reading your response wrong but implying that
@skamille is not humble, doesn’t collaborate, or lacks the ability to change her mind seems like a shitty take. -
It looks like you reached the wrong conclusion. Camille didn't say in her tweet that she questioned the value of CRs. She said she knew senior people who did.
- 3 more replies
New conversation -
-
-
It is also relatively easy for it to go awry when those social dynamics are off, but people would rather stop doing it than fix their team dynamics.
- End of conversation
New conversation -
-
-
It should be a team enforced review instead of top down. The team that owns the code should find value in reviewing it, instead of ticking a box so they can meet a deadline.
- 5 more replies
New conversation -
-
-
It just depends on the team. ive worked in places where the code review process has been absolutely brilliant for learning and knowledge transfer. ive also worked places where people with egos the size of the moon want to rewrite everything to prove how smart they are
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.
