For folks who missed yesterday's refterm stream - refterm v2 now handles splatting large binary files, VT code text decoration, massive line lengths (1gb in the demo), glyph size correction, and more:https://www.youtube.com/watch?v=99dKzubvpKE …
-
-
Replying to @cmuratori
In that video it looks like refterm's descenders are getting clipped. Very noticeable with the letter "g".
3 replies 0 retweets 2 likes -
Replying to @daniel_carvalho
It may very well be the case. One thing that is completely unexplored right now is getting text metrics. There's just a crap piece of code that calls DirectWrite - you can see it here:https://github.com/cmuratori/refterm/blob/4f20e81862603bfef9c2b9d9530477f6b7d72154/refterm_example_dwrite.cpp#L120 …
1 reply 0 retweets 3 likes -
Replying to @cmuratori @daniel_carvalho
It's entirely possible that either a) this code needs to be improved, and it's getting the wrong height, or b) the code that actually asks DirectWrite for the glyph needs to pass something different, and the result is that the glyphs are "too low".
1 reply 0 retweets 3 likes -
Replying to @cmuratori @daniel_carvalho
And it may also be the case that the squashing code (that tries to fix DirectWrite's sizing issues) is _also_ wrong. Since all of these were written without really knowing how DirectWrite works, there may be many problems :(
1 reply 0 retweets 3 likes -
Replying to @cmuratori @daniel_carvalho
However, none of them affect the rest of the code base, so if anyone wants to try to figure out how to set them correctly, everything else would magically just work.
1 reply 0 retweets 4 likes -
Replying to @cmuratori @daniel_carvalho
I opened an issue for it, though, so we'll remember to take a look:https://github.com/cmuratori/refterm/issues/26 …
1 reply 0 retweets 6 likes -
Replying to @cmuratori
Your point is still effectively made regarding the demo. I hope at the very least this provides motivation for the folks at Microsoft to improve Windows Terminal.
2 replies 1 retweet 9 likes
Also, the issue is fixed now :) So the actual refterm v2 that went out the door doesn't have this bug, it's only in the video.
-
-
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.