I'm sure it's possible, but that's instability I wouldn't really want to take on plus that would open us to getting our build broken by another team.
-
-
Replying to @Tyriar @cmuratori and
What
@Tyriar trying to say in previous comment, i think, is that refterm lacks the entire layer of handling legacy Win32 console apps, which includes actually a large portion of apps, including vim and far. Both conhost and WT does not have the luxury.1 reply 0 retweets 1 like -
Replying to @ChesterLiu2 @Tyriar and
That is false, as I demonstrated in the actual demo. The non-fast-pipe version, which was 10x faster than Windows terminal, _was going through conhost_.
1 reply 0 retweets 4 likes -
Replying to @cmuratori @ChesterLiu2 and
And separately, this is what I mean when I say it gets tiresome dealing with all of these nonsense excuses. People just say things on Twitter even though there was literally a demo _they could watch_ proving the thing that they said was false.
1 reply 0 retweets 3 likes -
Replying to @cmuratori @ChesterLiu2 and
So just to recap, if somehow watching the video was too difficult: _with_ backwards compat conhost, refterm is 10x faster than Windows terminal. If you _bypass_ that as a speed test, you get _another_ 10x faster, for a total of 100x. I explained this as clearly as I could.
1 reply 0 retweets 4 likes -
Replying to @cmuratori @ChesterLiu2 and
That is why I took great pains throughout the video to show the performance with _both_ fast_pipe.h and without, so you could see where each slowdown was.
1 reply 0 retweets 2 likes -
Replying to @cmuratori @ChesterLiu2 and
Sorry for all this. Reflecting on it a bit, it was a misunderstanding on my part, but I was truly just trying to be helpful. Here's where the confusion happened: - I hadn't heard the term "conio" before and messed it with stdio in some cases
2 replies 0 retweets 0 likes -
Replying to @Tyriar @cmuratori and
- You mentioned stdout of the proc which isn't what conpty provides - You mentioned you turns off VT parsing w/ setConsole which I took to mean you disabled an important emulation component of conpty - I was coding while listening to the majority of your video
1 reply 0 retweets 0 likes -
Replying to @Tyriar @ChesterLiu2 and
So these are little harder to address on Twitter but: you do not "turn off" VT parsing. It is off by default. What I said there was that I didn't _turn on_ conhost VT parsing. Windows doesn't parse VT codes by default, period. You have to call SetConsoleMode to turn it on.
1 reply 0 retweets 1 like -
Replying to @cmuratori @Tyriar and
So what I was trying to explain in that part of the video is that the conduit gets _even slower_ if you ask Windows to parse VT codes. What I showed was the _best case_ for Windows, where it _wasn't_ parsing VT codes.
1 reply 0 retweets 1 like
Finally, I'm not sure what you mean by "stdout of the process, which is not what conpty provides". Unless you know of some trickery that I do not, when you CreateProcess() on Windows, you _can't_ avoid the child process stdout being routed through conhost.
-
-
Replying to @cmuratori @Tyriar and
If you want to remove conhost from the loop you have to use the new ConPTY APIs and do your own thing.
0 replies 0 retweets 1 likeThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.