(11) [Consistent Rendering Quality] Finally- With the above, I was finally able to narrow down a scheme to make it so that the hunt to find the best version of what the model can render is a lot less tedious. Basically, it amounts to providing a render_factor (int) by the user
-
Show this thread
-
(12) and multiplying it by a base size multiplier of 16. This, combined with the square rendering, plays well together. It means that you get predictable behavior of rendering as you increase and decrease render_factor, without too many surprise glitches.
1 reply 0 retweets 1 likeShow this thread -
(13) Increase render_factor: Get more details right. Decrease: Still looks good but might miss some details. Simple! So you're no longer going to deal with a clumsy sz factor. Bonus: The memory usage is consistent and predictable so you just have to
1 reply 0 retweets 1 likeShow this thread -
(14) figure out the render_factor that works for your gpu once and forget about it. I'll probably try to make that render_factor determination automatic eventually but this should be a big improvement in the meantime.
1 reply 0 retweets 1 likeShow this thread -
(15) So that should be it! Code is committed, and again project is here: https://github.com/jantic/DeOldify/blob/master/README.md … and a Colab notebook to get you started immediately is here:https://colab.research.google.com/github/jantic/DeOldify/blob/master/DeOldify_colab.ipynb …
1 reply 0 retweets 7 likesShow this thread -
OH and p.s- Your'e not losing any image anymore with padding issues. That's solved as a biproduct. I wish all weeks were as productive as this!
1 reply 0 retweets 4 likesShow this thread -
Also also- I added a new generic filter interface that replaces the visualizer dealing with models directly. The visualizer loops through these filters that you provide as a list. They don't have to be backed by deep learning models- they can be any image modification you want!
1 reply 0 retweets 1 likeShow this thread -
Also also also- Need to give a shout out to MayeulC on Hacker News, who was the one who came up with the Chrominance optimization- a huge contribution. Original thread is here: https://news.ycombinator.com/item?id=18363870 …
1 reply 0 retweets 3 likesShow this thread -
Which brings me to another thought- I've already had a lot of great community contributions come in in various forms. It's wonderful! Thank you guys so much.
1 reply 0 retweets 2 likesShow this thread -
Replying to @citnaj
Thank you. This Twitter thread has so much to learn from.
1 reply 0 retweets 1 like
My pleasure. I figured it might at least be useful to somebody else doing something similar.
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.