Conversation

I've wondered about this. Anecdotally, the place I've worked with the best quality didn't do code review (maybe three "serious" user-visible bugs during the 8 years I was there, one of which was a fab issue that couldn't have been caught with any amount of code review).

Quote Tweet

Camille Fournier

@skamille

· Sep 6, 2019

Has anyone researched whether the benefit derived from mandatory code review are actually bigger than the cost of the slowdown in productivity waiting for approvals?

Show this thread

122

Dan Luu

@danluu

Sep 7, 2019

I know of a few places where people say that code reviews are the reason they have such great code quality (I've even worked at one of those places), but AFAIK they all ship a lot more bugs while moving slower.

Brendan Zabarauskas

@brendanzab

Replying to

@danluu

I like code review for teaching and knowledge sharing purposes - the same goes for the occasional pairing session. This _does_ come at the expense in short term forward velocity, but it would be interesting to see how much it pays off in the long term.

12:52 PM · Sep 7, 2019Twitter Web App