I started to do code reviews by pulling down the branch on my computer. For me it's easier to reason about the changes. What do you think?
-
-
Replying to @jodosha
I resist pulling branch for code reviews if it is someone I collaborate with regularly. Too tempting to play w/ code.
1 reply 0 retweets 0 likes -
-
Replying to @jodosha
"Play" meaning run / modify the tests and play with things in the REPL to see how things work. Maybe also try out changes I want to propose
2 replies 0 retweets 0 likes
I don't want to do these things though because it contradicts the point of the review. I want to just ask questions and avoid repeating work
2:23 PM - 28 Apr 2017
0 replies
0 retweets
0 likes
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.