I started to do code reviews by pulling down the branch on my computer. For me it's easier to reason about the changes. What do you think?
I resist pulling branch for code reviews if it is someone I collaborate with regularly. Too tempting to play w/ code.
-
-
Play == change it according to your thoughts?
-
"Play" meaning run / modify the tests and play with things in the REPL to see how things work. Maybe also try out changes I want to propose
-
I think that this playing is what I’m looking for stronger reviews.
-
I think it is fine to play with the code if you are reviewing code from someone you haven't worked with.
-
I think playing with the code locally though can sort of be a small violation of trust though if it is someone you are collaborating with
-
Sorry, but I don’t see why.
It’s not a matter of trust, but to increase the chances of spotting mistakes. This is good for the entire team. -
Like all engineering it depends on your priorities. If you are creating a high quality web framework without deadlines then probably fine.
-
I use to do this at work too.
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.