Ayaka NonakaVerified account

@ayanonagon @irace 3 mins that's a lot, and all is syntax changes?

@KostiaKoval Yeeeep. Unfortunate thing is that isActive = true is slower at runtime, so we’re trading off compile time with run time :/

@ayanonagon @KostiaKoval isn't it more important to make the user's experience better than the developer's?

@abizern @KostiaKoval It is, so I’m writing ugly code.

@ayanonagon btw, docs:"Typically, using this method is more efficient than activating each constraint individually." https://developer.apple.com/reference/uikit/nslayoutconstraint/1526955-activateconstraints …

Basically had to go back & change most of our NSLayoutConstraint.activate to isActive = true. Uglier, but it really added up over time…

@ayanonagon with a map it shouldn't be so ugly, or is it?

@KostiaKoval Map on what? Making the array itself is the slow part.

.@ayanonagon @irace I just tried it. Turns out { $0 == "e" || $0== "E" } takes 100ms more than { (c: Character) in c == "e" || c == "E" }

@ayanonagon @irace to be clear, that's for *every* instance. I had a function in SwiftFormat that has four of those; went from 400ms to 10ms

@ayanonagon @irace also, it's not a general problem using $0, it's the ||. This is an equally fast option: { "eE".characters.contains($0) }

@nicklockwood @ayanonagon @irace Hmm, I'm thinking it may have more to do with the Character literals combined with the ||.