Please don't squash commits on PRs: I have to re-read the whole PR (usually too big) each time. Github supports squash merges, or if you don't trust it, you can squash after you get the +1. KTHXBYE
-
-
Replying to @posco
*thinks through open PRs to see if it's me you're subtweeting*
1 reply 0 retweets 3 likes -
-
Replying to @posco @avibryant
I think I may be the one being subtweeted here, and my policy is if I've still got a [WIP] on it, I'm free to rebase (maybe I should reconsider, though).
2 replies 0 retweets 3 likes
Replying to @travisbrown @posco
That feels right to me. For me, WIP is "look at this if you are interested but don't review thoroughly yet". So rebases at that stage are legit.
6:43 PM - 31 Jan 2018
0 replies
0 retweets
1 like
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.