Code review feature: let code authors rate the usefulness of the reviews they get. Give reviewers only an aggregate view of how they're doing.
-
-
How about the code review system randomly injects bugs (only when showing the code to reviewers) and then records whether they were commented upon.
-
I think
@noradio used to do this manually. -
I've done things like that in the past, when I knew I had nitpickers in the review process. Rather than trying to make my code perfect, I intentionally left obvious things for them to nitpick about to draw their attention away fom the rest of the code.
#darkside -
This is a trick for CEO demo. Put something obviously wrong but easy to fix. CEO points it out rather than changes fundamental design with throwaway comment.
- 1 more reply
New conversation -
-
-
I think this impression may be based on a skewed experience, of which I'm jealous. I've worked at too many places where code reviews were actively adversarial.
-
Yeah so in my experience code reviews tend to be adversarial when done across team boundaries: 1. One instance is when a team feels very territorial about their code 2. Another instance is when a dev from a product team dumps a 3k line code review in some core service’s code base
-
And in any case a code review is not the right place to discuss a system’s architecture
End of conversation
New conversation -
-
-
No, whenever I insert a bug into the code it's obviously only because the code reviewer messed up.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.