@skamille @peterseibel @marius even with the best of intentions, the rubric devolves into "how much are they like us?" and diversity suffers
@HiveTheory @skamille @peterseibel @marius necessary that the code in question be directly written by you (rather than reviewed by, say)?
-
-
@avibryant@skamille@peterseibel@marius I think as you get more senior, the reviews you give others are more important than your own code. -
@HiveTheory@skamille@peterseibel@marius that’s my opinion also. If I were going to pick one body of work to review of a senior engineer, -
@HiveTheory@skamille@peterseibel@marius it would be their comments in code reviews and issues. -
@avibryant@skamille@peterseibel@marius As a manager reading the code reviews was also my #1 way to identify issues on the team. -
@avibryant@skamille@peterseibel@marius (don't get me wrong, I did 1:1s and such too, but code reviews were a great early warning system) -
@HiveTheory@avibryant@peterseibel@marius this is a fruitful topic. Would love to hear what you look for etc -
@skamille@avibryant@peterseibel@marius There's a ton! in rough order of priority: unresolved disagreements. 'tone of voice', is the... -
@skamille@avibryant@peterseibel@marius (are) the comments constructive? are people receptive? if not, what is the reasoning? are there... - 5 more replies
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.