Apparently in January I reverted an important change, and didn’t say why in the commit message.
*stares at self suspiciously*
Conversation
are commit messages not part of code review?
1
1
no. I’m pretty sure it was a “revert on branch bc not approved oops we merged the revert” scenarios
1
Replying to
fwiw phabricator keeps you from merging unreviewed stuff without extra audit steps
Replying to
yeah our phabricator instance is cobbled together in certain ways and a bit of an experiment still
1
Replying to
I must be doing something wrong; I don't seem to have checks (though I have audit hooks on anything in Perseus)
1