One of the things I found was good when I was a junior (and try to use now I am mentoring some) is to in code review ask questions, instead of informing that “x is wrong” to say “it looks like here you are doing {thing that looks incorrect} is this correct / intended?”
I’ve written some advice on how to mentor junior developers inspired by the talks @brightonruby I would really appreciate your thoughts on what works for you!
@sarahmei @nodunayo @vaidehijoshi #brightonrubyhttps://link.medium.com/1nK0pwu35X
-
-
-
I think the sentiment is right, but the question can come across as passive aggressive. I don’t think you should ask questions unless you’re interested in the answer. Instead of ‘x is wrong’ I would try to go with ‘x causes y, which would be a problem because…’
-
For me as an URM when learning, there was also a power dynamic: a LOT of questions, or questions to which the (majority group) asker obviously already knew the answer, felt like a test. "YOU FAILED. PLEASE LEAVE TECH NOW" is...not a background refrain conducive to concentration.
-
What is a URM? (I notice the irony of replying to this with a question - but I don’t know the answer ;)
-
Hah, questions like that are great! :) It's just barrages of them or clearly "I know a secret na na na na na" questions that are...
URM = under-represented minority. -
Thank you - I learned a thing
End of conversation
New conversation -
-
-
I’d have said your earn yourself a rest after yesterday but thanks for this - I’ve also been thinking about what I should be doing about this from the more experienced end of the spectrum.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
It is tricky - “what are you trying to do here?” (which I’ve tried variants on when something looks wrong to me) can easily come across as “justify your existence, puny human”
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.