A Moogle  🏳️‍🌈 💻 🎮 🎶 🇸🇪

1) One function that does everything. Many think that they should only create functions if they are reused. No. Create functions for anything that can be thought of as a generic action. This greatly helps in readability and structure.

2) No early exits int foo() { if(x) { // lots of code ... return y; } return 0; } Reverse that statement. Now the reader a lot to go through to make sure the "bad" exit case is ok If it's reversed, everything below the if does not matter for the "bad" case

3) Magic numbers everywhere. if (something > 5) ... What is this 5? Give it a name and put it somewhere. I see this so often, this number has context, show it.

4) One class for everything. Similar to one function for everything. If you can categorize the actions within the class, then you can make classes out of those categories. Not great to maintain a 6000 line class.

5) Inconsistent formatting style. Reading through code is a strain mentally, not only do you have to parse what each line is doing, you need to parse the structure. If it's inconsistent it makes it harder to parse. What style doesn't matter, just make it the same everywhere.

6) Comments everywhere. // Increment value by one i++; My issue with comments is that now you have 2 meanings for everything. The line has a meaning and the comment. And they must match, or else there is trouble. (continued)

6b) Add a comment when something needs explaining, when reading the code by itself would not make sense. But you can also just make a function that describes that action if it's complex enough, no comments needed then.

7) Performing complex actions in if statements if (myFoo->Action(aBar + aBaz->GetStuff(18))) The only time you should be placing direct actions in if statements is if you want to block the execution with an && Otherwise put that into a variable and then ask the question.