gotta admit the context here (Linux kernel) makes one wonder if they should be doing this
http://www.openwall.com/lists/kernel-hardening/2018/04/15/1 …
(via @mfukar)pic.twitter.com/BcoGCteN9D
You can add location information to your Tweets, such as your city or precise location, from the web and via third-party applications. You always have the option to delete your Tweet location history. Learn more
One detail I'm missing - are they actually calling with the wrong type, or casting back to call?
Former is utterly broken; latter is valid but hurts ability to detect type bugs.
I haven't looked at the code, but the original mail says "do not match" so I assume they're doing the really broken thing
With Linux I always assume it's the really broken thing unless proven wrong.
Here's some related "call with wrong function type" that resulted in _actual corruption of user state_ in kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=abafe5d9b0 …
TL;DR: they relied on first 2 slots of pt_regs overlapping with callee argument area to pass syscall args, and syscalls that made tail-calls happily clobbered the saved pt_regs.
yikes!
Nobody noticed until we ported musl to sh because all the existing users were stuck on CodeSourcery forks of gcc 4.5 or whatever that didn't do tail calls. :-P
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.