Welcome #Gerrit changes for #linux kernel:
https://linux-review.googlesource.com/c/virt/kvm/kvm/+/1464 …
and the mailing list version for contrast:
https://lore.kernel.org/lkml/20200123180436.99487-1-bgardon@google.com/T/#TerryJones …
Gerrit has side-by-side diffs, full expandable context, non-lossy comments attached to lines.
Here are docs:
https://linux.googlesource.com/Documentation/#gerrit-code-reviews-for-the-linux-kernel …
-
Prikaži ovu nit
-
Odgovor korisniku/ci @dvyukov
Incredible! How does it relate to the email-based system now? Do actions on either gerrit/email mirrored?
0 proslijeđenih tweetova 2 korisnika označavaju da im se sviđa -
Odgovor korisniku/ci @NedWilliamson
@Shiftreduce Well, as of now it's completely optional Annex to the process that is optional and does not affect anything. So you go to gerrit, review there, remember all comments in head then go to mailing list and post there [smiley or sad face on your choice].1 reply 0 proslijeđenih tweetova 3 korisnika označavaju da im se sviđa -
But! I find even that useful, e.g. yesterday I got this: https://groups.google.com/forum/#!topic/kasan-dev/8mmRUOFRi64 … You cannot make sense nor meaningfully review it without context (and generally you cannot even apply it locally because you don't know base tree/revision).
1 reply 0 proslijeđenih tweetova 2 korisnika označavaju da im se sviđa
I agree, it is simply so much more readable. The email-based patches are super hard to review quickly without using local tools.
Čini se da učitavanje traje već neko vrijeme.
Twitter je možda preopterećen ili ima kratkotrajnih poteškoća u radu. Pokušajte ponovno ili potražite dodatne informacije u odjeljku Status Twittera.