-
-
This Tweet is unavailable.
-
Replying to @LibertyFarmNH
Just code, commented out, with no explanation of why, is what really bothers me. And is what I mostly have run into. If they just left a "why I commented this out" comment i would be happy. Because otherwise it's a mystery to be solved.
1 reply 0 retweets 4 likes -
Replying to @ngvrnd @LibertyFarmNH
And I don't need more mysteries to be solved.
1 reply 0 retweets 3 likes -
Replying to @ngvrnd @LibertyFarmNH
yep. comments are great, write more of them. they aren’t a closet to keep old snippets of code. only villains do this.
2 replies 0 retweets 2 likes -
Replying to @djinnius @LibertyFarmNH
Although there are also misleading & incorrect comments. Comments like "fix this" which you EVENTUALLY learn from the AUTHOR are incorrect because "this", whatever it was, has BEEN FIXED. WHICH TURNS OUT TO BE A HABIT OF THE AUTHOR <pours more whiskey> <stares into the distance>
2 replies 0 retweets 5 likes -
Replying to @ngvrnd @LibertyFarmNH
Yep, reviewrs have a bad habit of ignoring comments in code review, which is a mistake. Is it in the source code? Ok then it’s code; review it
2 replies 0 retweets 2 likes -
Replying to @djinnius @LibertyFarmNH
I don't. I make suggestions for clarity and maintainability and I always insist on comment cleanup. Ppl actually seem to appreciate it.
2 replies 0 retweets 1 like
also: "fix this" is a phrase that belongs in a bug report, not the codebase a comment of the form "fix this; see PR #981" is ok tho
-
-
Totally agreed ; content is king mang.
0 replies 0 retweets 1 likeThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.