Essential if increasing quality is a main concern (should be the majority of the time)
Quality and code review. Would you say code review is optional, skip it when in a hurry? Or do you think it's a safety measure to prevent quality issues downstream? #testing #codereview #quality
-
-
-
I agree. But read this https://basecamp.com/shapeup/3.5-chapter-13#qa-is-for-the-edges … the person I'm trying to help agrees (tho not sure consequences are understood), so I'm trying to figure out how to help them see the value of safety nets.
- Još 6 drugih odgovora
Novi razgovor -
-
-
I’ve seen people skip code reviews in a hurry and felt like they did the right thing. Not every dev is comfortable carrying the risk alone and second pair of eyes is recommended but I’d let the dev make their own mistakes if overconfident.
-
Good point. That seems to presume some accountability mechanism (not shaming) that helps to reflect and decide to change something.
- Još 2 druga odgovora
Novi razgovor -
-
-
Never skip a code review. Even if it's one string change. Often times the author of the code is thankful when you point out issues. But also comment on something good as well for motivation. Quality is such an essential part of user value and it is everyone's responsibility.
-
It's a slippery slope to skip them which can lead to skipping them more. The less you skip and the better the CR practice, the less risk you carry even if you DO skip for some exceptional reason. But it's another matter if people don't seem to see the value in them at all...
Kraj razgovora
Novi razgovor -
-
-
If in a hurry, sometimes pairing with someone and therefore skipping the need to hand over a code review is quicker. Two heads are better than one, work on the context together, then you’ve confidence that it’s the best quality work you can with the current situation.
-
Fair point. I tend to prefer collaboration on the spot over hand-overs and this would align with it well.
Kraj razgovora
Novi razgovor -
-
-
My approach is "skip at your own peril". Code reviews have 3 goals: 1. Spotting mistakes 2. Ensuring code design is consistent 3. Teaching others about the code written. Trust people to know when to skip CR, and carry a big stick.
Hvala. Twitter će to iskoristiti za poboljšanje vaše vremenske crte. PoništiPoništi
-
Čini se da učitavanje traje već neko vrijeme.
Twitter je možda preopterećen ili ima kratkotrajnih poteškoća u radu. Pokušajte ponovno ili potražite dodatne informacije u odjeljku Status Twittera.