Possibly unpopular opinion, but I feel like "only merge things after verifying they are valid" should maybe be the default policy of the most used piece of software in the world.
Like, the Linux kernel maintainers are saying they can't tell if a patch is malicious so have to rely on the email address domain name.
Why are we focusing on the academics, this is a problem!
the whole "it's extremely difficult for us to verify that this kernel patch isn't malicious" business is a real indictment of C twitter.com/FiloSottile/st…
Although the Linux maintainers were inexcusably rude, running a study with intentional deception without consent or even coordinating with someone at the project in advance is against every ounce of human subjects training that I've received
I am not defending the academics but I don't rely on them to keep everything around me running and secure.
The maintainers' reaction is not rude, is concerning! It sounds like they rely on checking the evil bit to stop malicious patches.
What if HackingTeam has Gmail addresses?
My read is that they're annoyed about having their time wasted intentionally, not that they are blocking the domain as a security precaution, but I might be misunderstanding
The researchers were submitting correct patches too. They say that in 3 cases, they submitted intentionally incorrect patches and then told the maintainers it was wrong and provided the correct patch instead.
They were seemingly doing useful work on the kernel for the most part.
Lots of these patches appear to be correct fixes for memory corruption, etc. and are going to be reverted due to loss of trust in the authors. In reply to Greg's post on Twitter, a kernel maintainer states a patch to the code they maintain was correct but it's being reverted.
My impression is that the kernel maintainers are angry they were embarrassed this way and are reverting all of the useful work that was done out of spite.
I don't think this study was fully ethical but I don't think they were being malicious and appeared to be trying to help.
I don't think it's malicious. But the intransparency of the researchers along with the responses makes it a great deal worse. We still don't know which patches where part of the research, and that is a problem.
The research was unethical, but the problem goes far beyond that. Are they going to revert and review other similar patches which were not meaningfully understood, tested or reviewed? No, just these ones.
The process for accepting code does not counter bad actors well at all.
I don't think I agree with the revert, but I don't think you need this research to hilight the review problem with a project such as Linux either.
It just seems like cheap research to me.
I think it is needed as long as key people downplay the problems and try to make it seem like the status quo is fine.
Linux kernel code has very low quality and complexity far beyond a level that can be managed with the tools and processes that are being used, and they deny it.