Clang tidy's readability-magic-numbers check is a nightmare.
h_malloc.c:236:28: warning: 4096 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
static_assert(PAGE_SIZE == 4096, "bitmap handling will need adjustment for other page sizes");
Conversation
There are a couple cases where using an existing constant or defining a new one would make sense but it's mostly just noise:
gist.github.com/thestinger/b2f
The bugprone-too-small-loop-variable lint added alongside it in LLVM 8 is also annoying. Doesn't exclude constants it can check.
