Ok so here's an example of the context I have on a codebase that I can't figure out how to efficiently transfer to other reviewers:
-
Show this thread
-
Oh poo I messed up the thread. Fixing...
1 reply 0 retweets 0 likesShow this thread -
- PR comes in to move A to B - I remember that a while ago (sept), we moved B to A, so I knew to go look for that to remember why
1 reply 0 retweets 0 likesShow this thread -
- I looked at what the code used to look like before vs new proposal, found a difference
1 reply 0 retweets 0 likesShow this thread -
- That difference is important to one of the two places this code is called, neither of those places was changed in the PR
1 reply 0 retweets 0 likesShow this thread -
- So I knew the new PR probably wouldn't work for 1/2 places this code is called
1 reply 0 retweets 0 likesShow this thread -
How can I teach that, other than giving people time and opportunity to become familiar w/the whole codebase & its history...? idk.
2 replies 0 retweets 0 likesShow this thread -
Replying to @Carols10cents
My only answer I learned while working with you — consistent collaboration and review can fill in the unknowns and help prevent these type of changes from going through. Could tests have caught the failure case?
1 reply 0 retweets 3 likes
Yeah, unfortunately the test coverage isn't 100%, but I added one as a result of this situation :-/
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.