Ok so here's an example of the context I have on a codebase that I can't figure out how to efficiently transfer to other reviewers:
How can I teach that, other than giving people time and opportunity to become familiar w/the whole codebase & its history...? idk.
-
-
Not quite sure I’m totally following, but it sounds like you could write a test that would have failed for the PR? If tests are comprehensive, you don’t necessarily need to know the history.
-
Yeah, adding a test is what I ended up doing here :) We definitely don't have 100% coverage, unfortunately :(
End of conversation
New conversation -
-
-
My only answer I learned while working with you — consistent collaboration and review can fill in the unknowns and help prevent these type of changes from going through. Could tests have caught the failure case?
-
Yeah, unfortunately the test coverage isn't 100%, but I added one as a result of this situation :-/
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.