I’ve written some advice on how to mentor junior developers inspired by the talks @brightonruby I would really appreciate your thoughts on what works for you!
@sarahmei @nodunayo @vaidehijoshi #brightonrubyhttps://link.medium.com/1nK0pwu35X
One of the things I found was good when I was a junior (and try to use now I am mentoring some) is to in code review ask questions, instead of informing that “x is wrong” to say “it looks like here you are doing {thing that looks incorrect} is this correct / intended?”
-
-
I think the sentiment is right, but the question can come across as passive aggressive. I don’t think you should ask questions unless you’re interested in the answer. Instead of ‘x is wrong’ I would try to go with ‘x causes y, which would be a problem because…’
-
Agree, tweet cut down what I could say meaning it came across a bit passive aggressive in initial post, sorry
-
Also most of the time I am interested in how they got to this point, to try and work out if it is something I had not done correctly when explaining business case / bit they were working on
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.