I think we should move pg_stat_statement into core, and enable it by default in @PostgreSQL . #PostgreSQL
-
-
Replying to @DevrimGunduz @PostgreSQL
Enabling it by default can *significantly* reduce throughput, on bigger machines. I think we'd need to improve the locking logic internally before going there.
2 replies 1 retweet 3 likes -
Just ran a quick benchmark: If there's more statements than fit in pg_stat_statements I loose ca 55% on throughput, on my laptop. On multi-socket machines it's *much* worse.
1 reply 2 retweets 5 likes -
(Similar with longer querystrings and/or more different statements)
1 reply 1 retweet 3 likes -
There's difference between installing and enabling by default of course. What would be really good would be to by default have it loaded enough that you can turn it on/off without server restart. There are still far more systems that need it than not.
1 reply 1 retweet 3 likes -
Replying to @magnushagander @AndresFreundTec and
I haven't measured carefully but most of the overhead is gone if you load it but not enable the tracking, surely?
1 reply 0 retweets 2 likes -
Correct. And if we moved it to core, we could reduce the overhead of that case to just about zero (right now it's an additional set of indirect function calls, but we could just make it trivial branches). All I'm saying is that we can't enable it by default.
1 reply 0 retweets 2 likes -
Well, let's agree that we should put it in core to begin with. I'd say we *should* make it the default as long as it's trivial to turn off. Those that are processing that level of queries are already tuning their systems and turning one more knob would be easy..
1 reply 0 retweets 4 likes
I completely agree it should be in core. I absolutely disagree it's ok to knowingly regress workloads by 2-10x after an upgrade. Somebody needs to fix the locking before we can enable it by default.
-
-
Replying to @AndresFreundTec @magnushagander and
+1 for moving into core, even if disabled by default. Not requiring a restart to enable is a big win.
0 replies 0 retweets 4 likesThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.